Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Popover based on refactor #404

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

bruugey
Copy link
Collaborator

@bruugey bruugey commented Dec 6, 2024

And other component updates :)

@bruugey bruugey requested a review from stephl3 December 6, 2024 18:27
Copy link
Contributor

@stephl3 stephl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the double parentheses but curious if lint complains about that or not

@@ -57,7 +57,7 @@ export function ComponentCard() {
});

return (
<Card
(<Card
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does re-running lint get rid of these double parentheses?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not with the lint rules in this repo

@bruugey bruugey merged commit e242e59 into staging Dec 6, 2024
5 checks passed
@bruugey bruugey deleted the brooke/popover-codemod branch December 6, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants