Fix link to renamed and reformatted spec #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccho-mongodb
commented
Aug 16, 2023
source/fundamentals/monitoring.txt
Outdated
| @@ -148,17 +148,15 @@ The driver defines nine SDAM events. The driver divides these nine events | |||
| between three separate listener interfaces which each listen for three of the | |||
| nine events. Here are the three interfaces and the events they listen for: | |||
|
|
|||
| - ``ClusterListener``: :spec:`topology </server-discovery-and-monitoring/server-discovery-and-monitoring.rst#topology>` | |||
| related events | |||
| - ``ClusterListener``: topology related events | |||
There was a problem hiding this comment.
This is a Java/Kotlin event name and doesn't seem to correspond to anything in the spec, so I don't think the spec should be linked.
mongoKart
approved these changes
Aug 16, 2023
source/fundamentals/monitoring.txt
Outdated
| @@ -148,17 +148,15 @@ The driver defines nine SDAM events. The driver divides these nine events | |||
| between three separate listener interfaces which each listen for three of the | |||
| nine events. Here are the three interfaces and the events they listen for: | |||
|
|
|||
| - ``ClusterListener``: :spec:`topology </server-discovery-and-monitoring/server-discovery-and-monitoring.rst#topology>` | |||
| related events | |||
| - ``ClusterListener``: topology related events | |||
There was a problem hiding this comment.
S: hyphen for clarity (compound modifier)
Suggested change
| - ``ClusterListener``: topology related events | |
| - ``ClusterListener``: topology-related events |
ccho-mongodb
pushed a commit
that referenced
this pull request
Aug 16, 2023
(cherry picked from commit 49ad33b)
|
✨ Staging URL: https://docs-mongodborg-staging.corp.mongodb.com/kotlin/docsworker-xlarge/master/ 🪵 Logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - None
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/081623-fix-broken-links/fundamentals/monitoring/#server-discovery-and-monitoring-events
Self-Review Checklist