DOCSP-44608: merge v2 into master #174
Conversation
DOCSP-44239: v2 remove flags option
DOCSP-43953: v2 iterator changes
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| .. versionadded:: 1.17 | ||
|
|
||
| .. default-domain:: mongodb |
There was a problem hiding this comment.
I have no idea what this is used for, but isn't it included in many more pages within the PHPLIB docs? Or is this PR actually removing all references?
There was a problem hiding this comment.
I've only removed this from the pages that I've touched in this PR to avoid cluttering the "Files Changed"
There was a problem hiding this comment.
If it's not actually related to this PR would it make sense to do another that removes it everywhere in one shot?
There was a problem hiding this comment.
I can do that after merging this, sure!
jmikola
left a comment
jmikola
left a comment
There was a problem hiding this comment.
LGTM with capitalization fix.
source/whats-new.txt
Outdated
| - The fields ``contentType`` and ``aliases`` are no longer stored in | ||
| the ``files`` GridFS collection. If your application requires this | ||
| information, you must store it in metadata. To learn mor about | ||
| information, you must store it in metadata. To learn More about |
There was a problem hiding this comment.
| information, you must store it in metadata. To learn More about | |
| information, you must store it in metadata. To learn more about |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44608
Staging - https://deploy-preview-174--docs-php-library.netlify.app/whats-new/#what-s-new-in-2.0
Self-Review Checklist