DOCSP-48153: Add sync vs. async content to migration page #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-pymongo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mcmorisi
commented
Apr 2, 2025
|
|
||
| * - ``find_one_and_replace()`` | ||
| - .. code-block:: python | ||
| Asynchronous Methods |
There was a problem hiding this comment.
Note to tech reviewer – I cut this section down to just a link because I don't know if it makes sense to have two different sources of truth for async methods.
stephmarie17
requested changes
Apr 2, 2025
stephmarie17
approved these changes
Apr 3, 2025
NoahStapp
suggested changes
Apr 3, 2025
source/reference/migration.txt
Outdated
| {+driver-async+} driver. This is due to the {+driver-async+} driver using the native | ||
| ``asyncio`` library instead of thread-based executors. | ||
|
|
||
| Users experiencing performance slowdown should consider using synchronous {+driver-short+} |
There was a problem hiding this comment.
We should call out that users should first identify if they actually need to be using asynchronous Python here, or if their use case is better served by the synchronous API.
There was a problem hiding this comment.
Can take a stab at this in the next revision.
NoahStapp
suggested changes
Apr 3, 2025
source/reference/migration.txt
Outdated
| @@ -113,10 +113,15 @@ The following Motor method signatures behave differently in the {+driver-async+} | |||
|
|
|||
| Motor users may experience a degradation of performance when switching to the | |||
| {+driver-async+} driver. This is due to the {+driver-async+} driver using the native | |||
There was a problem hiding this comment.
Suggested change
| {+driver-async+} driver. This is due to the {+driver-async+} driver using the native | |
| {+driver-async+} driver. This is due to the {+driver-async+} driver using native |
source/reference/migration.txt
Outdated
|
|
||
| Users experiencing performance slowdown should consider using synchronous {+driver-short+} | ||
| with ``async.loop.run_in_executor()`` for asynchronous compatibility. To learn more, see | ||
| ``asyncio`` library instead of thread-based executors. Thread-based executors |
There was a problem hiding this comment.
Suggested change
| ``asyncio`` library instead of thread-based executors. Thread-based executors | |
| ``asyncio`` tasks instead of thread-based executors. Thread-based executors |
NoahStapp
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48153
Staging Links
Self-Review Checklist