Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-34476) Add cancellationToken parameter to Session.wait methods [Dart/Flutter] #3122

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

krollins-mdb
Copy link
Collaborator

@krollins-mdb krollins-mdb commented Dec 20, 2023

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-34476
Staged link: Manage a Sync Session: Added example for using cancellationToken.

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • Did you tag pages appropriately?
    • genre
    • meta.keywords
    • meta.description
  • Describe your PR's changes in the Release Notes section
  • Create a Jira ticket for related docs-app-services work, if any

Release Notes

  • Flutter SDK
    • Sync/Manage A Sync Session: Add cancellationToken parameter to Session.wait methods.

Review Guidelines

REVIEWING.md

Animal Wearing a Hat

- Fix broken test
- Generate new snippet
- Add new content to upload and download section
Copy link

Readability for Commit Hash: 37551dc

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/flutter/sync/manage-sync-session: Grade Level: 9.8, Reading Ease: 43.69

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

@krollins-mdb krollins-mdb marked this pull request as ready for review December 20, 2023 20:13
Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this LGTM. I do wonder if we should show this example with a TimeoutCancellationToken since I imagine that's probably the most common use case. But if folks follow the API reference link, they'll see that it's an option. I don't feel strongly so I'll let you decide if that makes sense or if you just want to wrap this up.

@krollins-mdb
Copy link
Collaborator Author

Hmm. I do think an example with TimeoutCancellationToken would be better, but I also think "good enough" works for now.

If we have the time and resources to polish the Dart/Flutter docs in the future, I'd like to see this concept addressed in more depth.

@krollins-mdb krollins-mdb merged commit e12dc29 into mongodb:master Dec 21, 2023
6 checks passed
@docs-builder-bot
Copy link

dacharyc added a commit that referenced this pull request Dec 21, 2023
## Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-35099

The remaining failing test is in `manage_sync_session_test.dart`, which
Kyle modified and may have fixed in #3122 ?

### Release Notes

- **Flutter SDK**
  - Internal: Fix failing code example tests related to SDK changes.

### Review Guidelines


[REVIEWING.md](https://github.com/mongodb/docs-realm/blob/master/REVIEWING.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants