Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-34729: Update Manage Subscriptions page with Subscribe API for Flutter #3124

Merged
merged 4 commits into from
Dec 26, 2023

Conversation

cbullinger
Copy link
Collaborator

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-34729

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • Did you tag pages appropriately?
    • genre
    • meta.keywords
    • meta.description
  • Describe your PR's changes in the Release Notes section
  • Create a Jira ticket for related docs-app-services work, if any

Release Notes

  • Flutter SDK
    • Sync Device Data/Manage Subscriptions: Update page to document the new Subscribe API with tested, Bluehawked code examples.

Review Guidelines

REVIEWING.md

Copy link

github-actions bot commented Dec 21, 2023

Readability for Commit Hash: e01540b

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/flutter/sync/manage-sync-subscriptions: Grade Level: 9.2, Reading Ease: 50.84
  • source/sdk/react-native/sync-data/flexible-sync: Grade Level: 8.0, Reading Ease: 59.09

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

Copy link
Collaborator

@krollins-mdb krollins-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor suggestions. I know some of these comments are on things that aren't part of what you updated, but it can be hard to tell with large page changes.

examples/dart/test/manage_sync_subscription_test.dart Outdated Show resolved Hide resolved
source/sdk/flutter/sync/manage-sync-subscriptions.txt Outdated Show resolved Hide resolved
source/sdk/flutter/sync/manage-sync-subscriptions.txt Outdated Show resolved Hide resolved
source/sdk/flutter/sync/manage-sync-subscriptions.txt Outdated Show resolved Hide resolved
source/sdk/flutter/sync/manage-sync-subscriptions.txt Outdated Show resolved Hide resolved
source/sdk/flutter/sync/manage-sync-subscriptions.txt Outdated Show resolved Hide resolved
cbullinger and others added 3 commits December 26, 2023 14:29
Co-authored-by: Kyle Rollins <115574589+krollins-mdb@users.noreply.github.com>
@cbullinger cbullinger merged commit 59ddcc3 into mongodb:master Dec 26, 2023
6 checks passed
@cbullinger cbullinger deleted the docsp-34729-subscribe-api branch December 26, 2023 19:52
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants