Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-35807: Add new Flutter getById() method to Connect to App page #3165

Merged
merged 3 commits into from
Jan 28, 2024

Conversation

cbullinger
Copy link
Collaborator

Pull Request Info

Jira ticket: https://jira.mongodb.org/browse/DOCSP-35807

  • Connect to App Services - Flutter SDK: Add new "Get App by ID" section with a tested, Bluehawked code example to document new getById() method, and update existing section with new behavior when opening an App on a background isolate.

Reminder Checklist

Before merging your PR, make sure to check a few things.

  • Did you tag pages appropriately?
    • genre
    • meta.keywords
    • meta.description
  • Describe your PR's changes in the Release Notes section
  • Create a Jira ticket for related docs-app-services work, if any

Release Notes

  • Flutter SDK
    • Atlas App Services/Connect to App Services: Add new "Get App by ID" section with tested, Bluehawked code example that documents how to access an App instance on a background isolate.

Review Guidelines

REVIEWING.md

Copy link

github-actions bot commented Jan 26, 2024

Readability for Commit Hash: 821291a

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/flutter/app-services/connect-to-app: Grade Level: 6.8, Reading Ease: 67.76

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

Copy link
Collaborator

@dacharyc dacharyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. Just a handful of Qs and a couple of nits you can feel free to disregard.

examples/dart/test/app_services_test.dart Show resolved Hide resolved
examples/dart/test/app_services_test.dart Outdated Show resolved Hide resolved
source/sdk/flutter/app-services/connect-to-app.txt Outdated Show resolved Hide resolved
source/sdk/flutter/app-services/connect-to-app.txt Outdated Show resolved Hide resolved
source/sdk/flutter/app-services/connect-to-app.txt Outdated Show resolved Hide resolved
@cbullinger cbullinger merged commit f6d4ce4 into mongodb:master Jan 28, 2024
6 checks passed
@cbullinger cbullinger deleted the docsp-35807-app-isolates branch January 28, 2024 20:42
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants