-
Notifications
You must be signed in to change notification settings - Fork 89
(DOCSP-39539): Consolidate Stream Data to Atlas page #3268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-39539): Consolidate Stream Data to Atlas page #3268
Conversation
Readability for Commit Hash: 178f5af You can see any previous Readability scores (if they exist) by looking Readability scores for changed documents:
For Grade Level, aim for 8 or below. For Reading Ease scores, aim for 60 or above:
For help improving readability, try Hemingway App. |
## Pull Request Info Jira ticket: https://jira.mongodb.org/browse/DOCSP-39161 - [Connect to App Services Backend](https://preview-mongodblindseymoore.gatsbyjs.io/realm/DOCSP-39161/sdk/dotnet/app-services/connect-to-app-services-backend/) - Note: Commented out failing tests. Fixing them will be a part of this ticket: https://jira.mongodb.org/browse/DOCSP-39638. ### Reminder Checklist Before merging your PR, make sure to check a few things. - [ ] Did you tag pages appropriately? - genre - meta.keywords - meta.description - [x] Describe your PR's changes in the Release Notes section - [ ] Create a Jira ticket for related docs-app-services work, if any ### Release Notes <!-- - **Kotlin** SDK - Realm/Manage Realm Files/Encrypt a Realm: Add information on encryption for local and synced realms. --> - .NET SDK - Application Services/Connect to an App Services App: Add a section on updating the base URL during runtime. ### Review Guidelines [REVIEWING.md](https://github.com/mongodb/docs-realm/blob/master/REVIEWING.md) --------- Co-authored-by: MongoCaleb <caleb.thompson@mongodb.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good 👍
source/includes/api-details/cpp/sync/stream-data-define-asymmetric-object-description.rst
Outdated
Show resolved
Hide resolved
database for Data Ingest, you *must* specify the ``asymmetric_object`` types | ||
you want to sync. | ||
|
||
.. tip:: Mixed Object and Asymmetric Object Types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this really doesn't seem like a tip
to me. I'd argue it should be incorporated into the above copy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong opinion about this. But I think it gets into subjective editorializing, which I don't think we necessarily have time to do as part of this project given the massive chunk of work that it represents. I think we should avoid rewriting/editing as much as possible, unless it's required to make the consolidated content work on the page.
source/includes/api-details/csharp/sync/stream-data-create-asymmetric-objects-description.rst
Outdated
Show resolved
Hide resolved
.. tab:: | ||
:tabid: csharp | ||
|
||
.. include:: /includes/dotnet-asymmetric-object.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're going for consistency: this include doesn't have "For more information on how to define an asymmetric object, refer to Define an Asymmetric Object." link, like all the others do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because it's an include that is also used on the data modeling page relative to asymmetric objects.
I guess I can remove it from here and just put a link out to the "define" page similar to the other SDKs.
- id: dart | ||
content: | | ||
|
||
.. literalinclude:: /examples/generated/flutter/open_flexible_sync_realm_test.snippet.open-flexible-sync-realm.dart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this snippet references a Tricycle
object in the schema instead of the WeatherSensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the snippet that's currently live on the page. I would guess it got updated and we didn't realize it was used in more than one place. I'll make a ticket in the Flutter Gaps epic to address this. 👍
@@ -0,0 +1,14 @@ | |||
Specify the ``AsymmetricObject`` types you want to sync. | |||
|
|||
.. note:: Mixed Synced and Non-Synced Databases in Projects |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any other restrictions in other SDKs re. mixing non- and asymmetric objects? or synced and non-synced dbs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I talked to engineering about it, it seemed like this was an issue specific to Swift and its use of reflection to infer realm/object schemas.
Co-authored-by: cbullinger <115956901+cbullinger@users.noreply.github.com>
a0659fc
into
mongodb:feature-consolidated-sdk-docs
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/realm/feature-consolidated-sdk-docs/ 🪵 Logs |
Pull Request Info - SDK Docs Consolidation
Jira ticket: https://jira.mongodb.org/browse/DOCSP-39539
Staged Page
Page Source
PR Author Checklist
Before requesting a review for your PR, please check these items:
feature-consolidated-sdk-docs
branch instead ofmaster
Naming
.rst
files comply with the naming guidelinesLinks and Refs
Content
Reviewer Checklist
As a reviewer, please check these items: