-
Notifications
You must be signed in to change notification settings - Fork 89
(DOCSP-39500): Consolidate Install page #3326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DOCSP-39500): Consolidate Install page #3326
Conversation
Readability for Commit Hash: 889f315 You can see any previous Readability scores (if they exist) by looking Readability scores for changed documents:
For Grade Level, aim for 8 or below. For Reading Ease scores, aim for 60 or above:
For help improving readability, try Hemingway App. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I only have some relatively minor suggestions and comments.
Nice work, @dacharyc!
To include these manifests in a build target that uses ``Realm``, you must | ||
build ``Realm`` as a dynamic framework. For details, refer to the Swift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double checking: do these instances of "Realm" refer to the realm package? If so, should we make that a bit clearer to help with the distinction between the package being called "realm" but the product being called "Atlas Device SDK"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comes up again in the "Supported Target Environments" section with Xcode compatibility info.
.. step:: Update the CocoaPods repositories | ||
|
||
On the command line, run ``pod repo update`` to ensure | ||
CocoaPods can access the latest available Realm versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "Realm" instance feels like it should be updated, but I'm not certain of the context.
source/sdk/install.txt
Outdated
|
||
.. tip:: Atlas Device SDK and Realm | ||
|
||
The SDK uses Realm Core database for device data persistence. When you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion to avoid making it seem like Realm Core persists data about the device itself. Would apply to the other note too.
The SDK uses Realm Core database for device data persistence. When you | |
The SDK uses Realm Core database for on-device data persistence. When you |
@@ -0,0 +1 @@ | |||
- :ref:`sdks-build-for-android` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do people use the C++ SDK for Android projects? I thought it mostly IoT/embedded type stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we had customers running into issues related to this which is why we had to add the info about it. I'm not sure about the context - maybe in cross-platform projects?
@@ -0,0 +1,15 @@ | |||
- :ref:`sdks-unity` | |||
|
|||
When building for Apple platforms, Apple requires any apps or third-party SDKs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need the "Apple Privacy Manifest" heading here, like in the Swift and Objective-C details. Otherwise, this manifest content kinda comes out of nowhere. Looks like the heading is needed for Dart and Kotlin details too.
The latest version of the SDK requires Dart version {+dart-minimum-version+} | ||
or later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you didn't write this, but it seems more important in the new context.
Minor update to make it clear we're talking about the Atlas Device SDK and not the Dart SDK (which is what the previous link calls the Dart language environment).
The latest version of the SDK requires Dart version {+dart-minimum-version+} | |
or later. | |
The latest version of the Atlas Device SDK requires Dart version {+dart-minimum-version+} | |
or later. |
- **Mobile App Development**: For cross-platform mobile app development, use | ||
the :ref:`sdks-build-with-react-native`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording is a bit odd when this gets expanded to the page title.
- **Mobile App Development**: For cross-platform mobile app development, use | |
the :ref:`sdks-build-with-react-native`. | |
- **Mobile App Development**: For cross-platform mobile app development, refer | |
to :ref:`sdks-build-with-react-native`. |
`Kotlin Multiplatform documentation | ||
<https://kotlinlang.org/docs/mobile/create-first-app.html>`__. | ||
|
||
For more details on setting up your KMP environment, refer to the `official Kotlin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more details on setting up your KMP environment, refer to the `official Kotlin | |
For more details on setting up your KMP environment, refer to the `official |
✅ Deploy Preview for device-sdk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7f294fe
into
mongodb:feature-consolidated-sdk-docs
Pull Request Info - SDK Docs Consolidation
Jira ticket: https://jira.mongodb.org/browse/DOCSP-39500
Notes for Reviewer
Only five of the pages listed here should be considered to be in a "complete" state as of this PR:
I moved content off of existing install pages onto a bunch of other pages, but those pages will get more updates in the future to make them coherent pages. For now, you only need to confirm that the content got moved successfully and everything is still working.
Also, noting here that per conversations with the product and engineering teams, we are intentionally omitting the Java SDK (Java and Java-Kotlin) from the Install page.
Staged Page
hidden-pages
directory. I don't think this is necessarily important enough to surface in the ToC, and we don't have a good pattern for doing that in the new consolidated world. It's available in the "Upgrade" section, and we could link to it elsewhere if we come up with a better pattern later.Page Source
Add links to every SDK's pages where you got the SDK-specific information:
PR Author Checklist
Before requesting a review for your PR, please check these items:
feature-consolidated-sdk-docs
branch instead ofmaster
Naming
.rst
files comply with the naming guidelinesLinks and Refs
Content
Reviewer Checklist
As a reviewer, please check these items: