Skip to content

(DOCSP-41633): Consolidation: Incorporate Counter and Progress Notifications updates #3331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dacharyc
Copy link
Collaborator

@dacharyc dacharyc commented Jul 19, 2024

Pull Request Info - SDK Docs Consolidation

Jira ticket: https://jira.mongodb.org/browse/DOCSP-41633

Re: counters, the only info I'm pulling in here is for the "Create" page. The rest of the Counter info will be incorporated as we work on other PRs in the consolidation project (for defining a counter property and updating a counter property).

Staged Page

Page Source

Add links to every SDK's pages where you got the SDK-specific information:

PR Author Checklist

Before requesting a review for your PR, please check these items:

  • Open the PR against the feature-consolidated-sdk-docs branch instead of master

Reviewer Checklist

As a reviewer, please check these items:

  • Shared code example boxes contain language-specific snippets or placeholders for every language
  • API reference details contain working API reference links or generic content
  • Realm naming/language has been updated
  • All relevant content from individual SDK pages is present on the consolidated page

@dacharyc dacharyc added the merge to feature branch Unreleased feature - do not merge to Master label Jul 19, 2024
Copy link

netlify bot commented Jul 19, 2024

Deploy Preview for device-sdk ready!

Name Link
🔨 Latest commit 4df7a93
🔍 Latest deploy log https://app.netlify.com/sites/device-sdk/deploys/669adac117087f000823b42b
😎 Deploy Preview https://deploy-preview-3331--device-sdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 27 (🟢 up 6 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 75 (no change from production)
SEO: 62 (🔴 down 7 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jul 19, 2024

Readability for Commit Hash: 4df7a93

You can see any previous Readability scores (if they exist) by looking
at the comment's history.

Readability scores for changed documents:

  • source/sdk/crud/create/create-property-types: Grade Level: 8.8, Reading Ease: 51.65

For Grade Level, aim for 8 or below.

For Reading Ease scores, aim for 60 or above:

Score Difficulty
90-100 Very Easy
80-89 Easy
70-79 Fairly Easy
60-69 Medium
50-59 Fairly Hard
30-49 Hard
0-29 Very Hard

For help improving readability, try Hemingway App.

Copy link
Collaborator

@krollins-mdb krollins-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @dacharyc!

@dacharyc dacharyc merged commit c63b55c into mongodb:feature-consolidated-sdk-docs Jul 22, 2024
10 checks passed
@dacharyc dacharyc deleted the incorporate-counters branch July 22, 2024 22:01
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge to feature branch Unreleased feature - do not merge to Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants