Skip to content

(DOCSP-42045): Fix wrong C++ tab ID #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dacharyc
Copy link
Collaborator

@dacharyc dacharyc commented Aug 1, 2024

Pull Request Info - SDK Docs Consolidation

Jira ticket: https://jira.mongodb.org/browse/DOCSP-42045

Staged Page

  • Manage Sync Sessions: Page correctly changes code examples when you switch language tabs.
  • Help: The Help page was using realm-sdks tab set - I changed it to Drivers tab set so it would preserve the language selection when the user switched to the page. I also added a couple of notes related to naming because there are some naming things here that still reflect the old name, and we can't change them.

@dacharyc dacharyc added the merge to feature branch Unreleased feature - do not merge to Master label Aug 1, 2024
Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for device-sdk ready!

Name Link
🔨 Latest commit 6d8a7e0
🔍 Latest deploy log https://app.netlify.com/sites/device-sdk/deploys/66abb6d31a208e0008accf32
😎 Deploy Preview https://deploy-preview-3353--device-sdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 24 (🔴 down 1 from production)
Accessibility: 92 (🔴 down 1 from production)
Best Practices: 75 (no change from production)
SEO: 62 (🔴 down 7 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@krollins-mdb krollins-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing the tabset and updating the help page. 🥇

@dacharyc dacharyc merged commit d492af4 into mongodb:feature-consolidated-sdk-docs Aug 1, 2024
9 checks passed
@dacharyc dacharyc deleted the DOCSP-42045 branch August 1, 2024 20:00
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge to feature branch Unreleased feature - do not merge to Master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants