-
Notifications
You must be signed in to change notification settings - Fork 1.7k
made edits, but left some TODOs for you #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll merge in tomorrow. Eliot's proof'd http://docs.mongodb.org/manual/tutorial/expire-data/ and the new section is consistent with that. |
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
May 22, 2025
* DOCSP-23350 write-blokcing note * staging updates * Review feedback * Review feedback * Review feedback * Review feedback * Review feedback
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
May 22, 2025
* DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration Setting/Option Map * DOCSP-22863 Configuration Setting/Option Map * DOCSP-22863 Configuration introduction * DOCSP-22863 Test cluster0 include * DOCSP-22863 Include updates * DOCSP-22863 Spelling * DOCSP-22863 Typo * DOCSP-22863 header content * DOCSP-22863 Alphabetizes CLI options * DOCSP-22863 Reorders TOC * DOCSP-22863 Fixes per Alan Zheng * DOCSP-22863 Fixes per Ian Fogelman * DOCSP-22863 Fixes per Ian Fogelman * DOCSP-22863 Fixes per Alan Zheng * DOCSP-22863 Fixes build error * DOCSP-22863 Fixes build error * DOCSP-22863 Fixes build error * DOCSP-22863 Fixes build error * DOCSP-23350 write-blocking note (#52) * DOCSP-23350 write-blokcing note * staging updates * Review feedback * Review feedback * Review feedback * Review feedback * Review feedback * DOCSP-23337 users and roles not synched (#55) * DOCSP-23337 users and roles not synched * Review feedback * Review feedback * DOCS-15427 System Collection Limitations (#59) * DOCS-15427 Adds System Collection limitation * DOCS-15427 Adds System Collection limitation * DOCS-15427 Fixes per Joe * DOCS-15427 Fixes per Joe * Merge with upstream master * Merge with upstream master * Merge with upstream master * Merge with upstream master * DOCSP-22863 Alphabetizes CLI options * DOCSP-22863 Build errors * DOCSP-22863 Build errors * DOCSP-22863 Build errors * DOCSP-22863 Fixes per Tim Fogarty * DOCSP-22863 Increases depth on mongosync * DOCSP-22863 Fixes per Tim Fogarty * DOCSP-22863 Fixes build error Co-authored-by: Dave Cuthbert <69165704+davemungo@users.noreply.github.com>
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jun 2, 2025
DOCSP-20368: Removing obsolete file from repo
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
DOCSP-33185 Stop / Resume Sync Job Considerations
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
* DOCSP-10925: document uuid format strategy
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
* DOCSP-11107 describe how to retrieve iamAssumedRoleArn (#54) * DOCSP-11107 describe how to retrieve iamAssumedRoleArn * DOCSP-11107 updates for tech review feedback * DOCSP-11233 creation API returns user ARN and External ID (#52) * DOCSP-11233 creation API returns user ARN and External ID DOCSP-11233 self-review DOCSP-11233 typo fix * DOCSP-11233 updates for tech review feedback DOCSP-11233 minor fix * DOCSP-11908 api doc for updating adl (#63) * DOCSP-11908 api doc for updating adl * DOCSP-11908 self-review DOCSP-11908 fixing broken includes * DOCSP-11908 updates for external review feedback DOCSP-11908 minor tweak * Apply suggestions from code review accepting copy review changes Co-authored-by: Chris Bush <chris.bush@10gen.com> Co-authored-by: Chris Bush <chris.bush@10gen.com> * DOCSP-11810 api doc for creating adl (#62) * DOCSP-11810 api doc for creating adl DOCSP-11810 self-review DOCSP-11810 self-review DOCSP-11810 self-review DOCSP-11810 self-review DOCSP-11810 response updates DOCSP-11810 self-review DOCSP-11810 fixing includes * DOCSP-11810 update for tech review * Apply suggestions from code review accepting proposed copy review feedback Co-authored-by: Chris Bush <chris.bush@10gen.com> Co-authored-by: Chris Bush <chris.bush@10gen.com> * DOCSP-11588 doc for unified AWS access (#53) * DOCSP-11588 doc for unified Atlas access DOCSP-11588 minor corrections DOCSP-11588 doc fix DOCSP-11588 fixes DOCSP-11588 doc updates * DOCSP-11588 updates for tech review feedback DOCSP-11588 minor fix DOCSP-11588 fixing links DOCSP-11588 minor typo fix * DOCSP-11588 updates for external review feedback DOCSP-11588 minor tweak * DOCSP-11588 updates for review feedback DOCSP-11588 minor typo Co-authored-by: Chris Bush <chris.bush@10gen.com>
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
Co-authored-by: Jordan Smith <45415425+jordan-smith721@users.noreply.github.com>
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
* added intro to changeStream section * init change stram commit * update toc tree * update verbiage * update link * updated verbiage * added code snippet * updated rst syn * updated verbiage * updated verbiage * updated verbiage * updated verbiage * updated link to node-api role * (DOCSP-7905): adopted node-api role * updated formatting * added link to promise def * fixed spacing * updated formatting * updated verbiage * fixed formatting * updated verbiage * updated verbiage * added dup page for rough draft purposes * added dup page for rough draft purposes * update change stream verbiage * Cleaned up formatting * updated copy for example * fixed formatting * updated formatting * added headers and updated verbiage * added headers and updated verbiage * Fixed formatting * removed unneeded var * update verbiage * update mdn link * added event emitter link and added verbiage fix * updated code * cleanup of doc * more formatting fixes * improve formatting * updated code snippet to remove specific uri and clean client * removed 'real-world' wording for PR comment * updated verbiage * update verbiage * update verbiage * update verbiage to address PR comments * update formatting * clarified code comment * (DOCSP-7905): updated verbiage to address pr comments * update example paragraph * update verbiage * update verbiage * update code * updated code comments * fixed spacing * fixed verbiage * fixed verbiage per commentS * Removed unneeded vars * update verbiage to address comments * fixed verbiage * Fix punctuation Co-Authored-By: Chris Bush <chris.bush@10gen.com> * Fix punctuation Co-Authored-By: Chris Bush <chris.bush@10gen.com> * fixed verbiage to adhere to PR comment * update verbiage * added additional links * updated more links * update highlighting * fixed quote mark * fixed verbiage for consistency * fixed formatting Co-authored-by: Chris Bush <chris.bush@10gen.com>
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
* connection * connection includes * BD feedback * fix links * autobuilder * wip * DL feedback * BD feedback * fix list * formatting * formatting * formatting * formatting * formatting * formatting * formatting * formatting * formatting * formatting Co-authored-by: Mike Woofter <mike.woofter@mongodb.com>
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2025
DOCSP-9550 POJO customization
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2025
(cherry picked from commit d3b8444)
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2025
* DOCSP-42308: Deployment and connection string (#52) * DOCSP-42308: Deployment and connection string * add file * DOCSP-42306: Get Started and Install (#51) * Get Started and Install * build * edits * wording * troubleshooting file * version * JS feedback * DOCSP-42310: Connect to MongoDB (#53) * DOCSP-42310: Connect to MongoDB * edits * code highlight * reduce scroll * DOCSP-42305: Index page + repo cleanup (#56) * DOCSP-42321: Insert landing page (#55) * DOCSP-42329: Retrieve data (#54) * DOCSP-42329: Retrieve data * edits * MM feedback * DOCSP-42321: Insert Documents (#61) * DOCSP-42328: Specify a query (#57) * DOCSP-42328: Specify a query * link fix * edit * JS feedback * output * RL feedback * DOCSP-42330: Projection guide (#58) * DOCSP-42330: Projection guide * edits * add constant * MM fix * DOCSP-42323: Replace (#62) * DOCSP-42331: Specify docs to return (#64) * DOCSP-42331: Specify docs to return * toc * MM feedback * code output * DOCSP-42322: Update (#63) * DOCSP-42332: Count documents (#66) * DOCSP-42332: Count documents * edits * build errors * RR feedback * scroll * build error * DOCSP-42312 Create a MongoDB Client (#59) * DOCSP-42312 Create a MongoDB Client * on TOC * retry TOC * build * api doc * fix links * code fix * review comments * test * test * fix snooty * merge error * DOCSP-42324: Delete (#65) * DOCSP-42325: Bulk Write (#68) * DOCSP-42317: Databases and Collections (#77) * DOCSP-42333: Distinct values (#67) * DOCSP-42333: Distinct values * edits * build error * RR feedback * DOCSP-42335: Change streams (#69) * DOCSP-42335: Change streams * code * edits * fixes * toc * MW feedback * MW feedback * fix * DOCSP-42311: Run a Command (#75) * DOCSP-42311: Run a Command * edits * code edits * MM feedback * JY feedback * DOCSP-42318: Time Series (#78) * DOCSP-42326: GridFS (#72) * DOCSP-42342: Aggregation (#71) * DOCSP-42342: Aggregation * edits * code imports * RR feedback * import fixes * JY feedback * DOCSP-42316: Stable API (#81) * DOCSP-42336: Cluster monitoring (#73) * DOCSP-42336: Cluster monitoring * edits * fixes, code edit * MM feedback * remove unused imports * fix indent * DOCSP-42341: Atlas Search Indexes (#82) * Uncomment link to compat tables on landing page (#84) * DOCSP-40287: Read landing page (#85) * DOCSP-42343: Secure Your Data + Authentication Mechanisms (#83) * DOCSP-42319: Read and write settings (#79) * DOCSP-42319: Read and write settings * edits * code comments * MW feedback * code edits * JY feedback * imports * edits * JY feedback 2 * build * DOCSP-42338 Single Field Indexes (#70) * DOCSP-42338 Single Field Indexes * new content * first draft * fix toc * try section heading * fixes * fix links * ref fix * review comments * add helper method import * helper method explanation * edit helpers section * edicts * edit * edit out helpers * edict copy * fix database * unnecessary imports * DOCSP-42339 Compound Indexes (#74) * DOCSP-42339 Compound Indexes * toc * fix examples * 1 review comment * api comment * spacing * remove helpers * fix scroll * edits * edit output spacing * DOCSP-42314: Enable TLS (#88) * DOCSP-42314: Enable TLS * edits * code comments * intro edit * DOCSP-42337: Optimize Queries with Indexes (#92) * DOCSP-42349: Transactions (#89) * DOCSP-42349: Transactions * edits * JS feedback * JY feedback * DOCSP-42340 Multikey Index (#76) * DOCSP-42340 Multikey Index * fixes * multikey index link * text fix * internal review comments * remover helpers * edits * uri * DOCSP-42313 Connection Targets (#80) * DOCSP-42313 Connection Targets * toc * fixes * code fix * small change * sode file endline spacing * review edits * comment out connection option page * Correct connect section TOC * DOCSP-42334: Observables (#86) * DOCSP-42334: Observables * edits * fix error * MM feedback * edits * word * MM feedback 2 * edit * build * JY feedback * JY feedback 2 * edit * DOCSP-24494: Atlas search section (#90) * DOCSP-24494: Atlas search section * edits * imports * admonitions * code output * rename headers * MR feedback * edits * JY feedback * DOCSP-42346: Upgrade driver (#91) * DOCSP-42346: Upgrade driver * edits * MW feedback * edits, link fixes * MW final feedback * JY feedback * DOCSP-45354: TOC labels (#94) * add labels * LM feedback * DOCSP-45348: Cleanup (#93) * DOCSP-45348: Cleanup * edits * TODOs * add back in-use encryption * edits * sharedinclude fixes * fix link * RR feedback * staging link * fixes --------- Co-authored-by: Michael Morisi <michael.morisi@mongodb.com> Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com> Co-authored-by: Maya Raman <maya.raman19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a variety of edits, but left some TODO's for you to fill in. Also, I didn't really check the TTL part, since it's new and I'm not familiar with it. You should have Eliot proof that.
I'm happy to do another pass if needed later. Let me know if you have any questions.