feat(ipa0114): Add rate limiting guidelines to errors IPA #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-condon
requested review from
andmatei,
andreaangiolillo,
drinkbird,
lovisaberggren,
wtrocki and
yelizhenden-mdb
matt-condon
changed the title
matt-condon
force-pushed
the
CLOUDP-366822
branch
from
5758947 to
7b2b238
Compare
matt-condon
commented
Dec 18, 2025
ipa/general/0114.md
Outdated
Comment on lines
68
to
71
| - APIs **must** include the `Retry-After` HTTP response header when returning | ||
| `429 Too Many Requests` to indicate when the client can retry the request. | ||
| - The `Retry-After` header value **must** be expressed as time in seconds | ||
| until the next token is available. |
Collaborator
There was a problem hiding this comment.
Suggested change
| - APIs **must** include the `Retry-After` HTTP response header when returning | |
| `429 Too Many Requests` to indicate when the client can retry the request. | |
| - The `Retry-After` header value **must** be expressed as time in seconds | |
| until the next token is available. | |
| - APIs **should** include the `Retry-After` HTTP response header when returning | |
| `429 Too Many Requests` to indicate how long the client should wait before retrying the request. | |
| - The `Retry-After` header value **must** be expressed as time in seconds | |
| until the next request can be made. |
I think the Retry-After should be a guideline and not necessarily a must, similarly to the rate limit headers
ipa/general/0114.md
Outdated
Comment on lines
74
to
77
| - `RateLimit-Limit`: The maximum number of requests allowed in the current | ||
| rate limit window (bucket capacity) | ||
| - `RateLimit-Remaining`: The number of requests remaining in the current rate | ||
| limit window (remaining tokens) |
Collaborator
There was a problem hiding this comment.
Q: Should we use token bucket specific language? Or refer to maximum requests and remaining requests?
Collaborator
Author
There was a problem hiding this comment.
Good point, I think we actually shouldn't use token bucket specific language since there could be a different implementation and the headers aren't specific to token bucket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CLOUDP-366822
Add rate limiting guidelines to errors IPA
Note: Will be merged as a post-rollout action