chore(NODE-5362): update benchmark tooling #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

durran merged 5 commits into main from improve-benchmark-tooling

Jun 23, 2023

Contributor

W-A-James commented Jun 16, 2023 •

edited

Loading

Description

What is changing?

Adds a script that allows for easier installation of older bson versions for performance testing
Adds a script that converts benchmark output to easily ingestible csv data
Updates etc/benchmarks/lib_runner.js to more cleanly test old bson versions and generate clearer tabular output

Is there new documentation needed for these changes?

No, these are internal

What is the motivation for this change?

Making bson benchmarking easier following the investigation of NODE-4283

Double check the following

Ran npm run lint script
Self-review completed using the steps outlined here
PR title follows the correct format: type(NODE-xxxx)[!]: description
- Example: feat(NODE-1234)!: rewriting everything in coffeescript
Changes are covered by tests
New TODOs have a related JIRA ticket

W-A-James added 2 commits

June 16, 2023 15:16


          chore(NODE-4283): update benchmark tooling

581b51e


          chore: update script

b4fd977

W-A-James changed the title ~~chore(NODE-4283): update benchmark tooling~~ chore: update benchmark tooling

W-A-James marked this pull request as ready for review

June 20, 2023 14:14

Contributor

dariakp commented Jun 20, 2023

@W-A-James Could you create a subtask on NODE-4283 to track this work?

W-A-James changed the title ~~chore: update benchmark tooling~~ chore(NODE-5362): update benchmark tooling

durran self-assigned this

durran added the Primary Review label

durran reviewed

View reviewed changes

etc/benchmarks/convert_to_csv.sh Outdated Show resolved Hide resolved

durran reviewed

View reviewed changes

etc/benchmarks/convert_to_csv.sh Outdated Show resolved Hide resolved

durran reviewed

View reviewed changes

etc/benchmarks/convert_to_csv.sh Outdated Show resolved Hide resolved

durran reviewed

View reviewed changes

etc/benchmarks/convert_to_csv.sh Outdated Show resolved Hide resolved

durran reviewed

View reviewed changes

etc/benchmarks/convert_to_csv.sh Outdated Show resolved Hide resolved

durran reviewed

View reviewed changes

etc/benchmarks/install_bson_versions.sh Outdated Show resolved Hide resolved

durran requested changes

View reviewed changes

Member

durran left a comment

Nice table. :)

W-A-James and others added 3 commits

June 21, 2023 15:49


          Update etc/benchmarks/convert_to_csv.sh

72b6746

Co-authored-by: Durran Jordan <durran@gmail.com>


          Apply suggestions from code review

1de3b7c

Co-authored-by: Durran Jordan <durran@gmail.com>


          chore(NODE-5362): simplify sed script and implement code review feedback

d8c1fa4

W-A-James requested a review from durran

June 21, 2023 20:06

durran added Team Review and removed Primary Review labels

durran approved these changes

View reviewed changes

W-A-James commented

View reviewed changes

etc/benchmarks/bson_versions.json Show resolved Hide resolved

durran merged commit bc95ab4 into main

durran deleted the improve-benchmark-tooling branch

June 23, 2023 10:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels