Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-5768): add comment trigger for release notes #638

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

A comment "run release_notes" from an admin will now trigger the release notes automation. The workflow dispatch also works.

Is there new documentation needed for these changes?

Will update the release instructions document.

What is the motivation for this change?

Commenting on the release PR is a more convenient UX than the workflow dispatch. This also removes the need to select the branch from that pane as we checkout the ref based on PR number.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@W-A-James W-A-James self-assigned this Nov 30, 2023
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 30, 2023
@W-A-James W-A-James merged commit 99cd066 into main Nov 30, 2023
3 of 4 checks passed
@W-A-James W-A-James deleted the NODE-5768-comment-auto-notes branch November 30, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants