Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6018): run entire BSON suite on a big endian machine #726

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Nov 13, 2024

Description

What is changing?

  • Add entire suite to zSeries machines to get full coverage on a big endian machine
  • Adds Node.js 22 to BSON CI and bump to 22 in tasks that are node version agnostic
  • Skip npm pack test (unnecessary to run on more than one platform)
  • fix double test for big endian environment
  • Upgraded to RHEL 9 on zSeries because rollup requires GLIBC 2.29+
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Prepare for future feature work that is endian sensitive.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review November 13, 2024 04:00
@baileympearson baileympearson self-assigned this Nov 13, 2024
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Nov 13, 2024
@baileympearson baileympearson added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Nov 13, 2024
@W-A-James W-A-James self-requested a review November 13, 2024 19:38
@baileympearson baileympearson merged commit 887849d into main Nov 13, 2024
8 checks passed
@baileympearson baileympearson deleted the NODE-6018-s390x branch November 13, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants