Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix for mongodb #1920

Merged
merged 3 commits into from
Jan 22, 2020
Merged

Conversation

Smolevich
Copy link
Contributor

  • Create matrix mongodb with versions 3.6, 4.0, 4.2

"Closes: #1918"

@Smolevich Smolevich self-assigned this Jan 21, 2020
@jenssegers
Copy link
Contributor

That coveralls dependency is really being annoying. Might be better to just disable it for now.

@Smolevich
Copy link
Contributor Author

That coveralls dependency is really being annoying. Might be better to just disable it for now.

We can use case as webonyx (webonyx/graphql-php@599b03b) or use https://github.com/cedx/coveralls.php before accepting this PR php-coveralls/php-coveralls#275

@Smolevich
Copy link
Contributor Author

Smolevich commented Jan 22, 2020

@jenssegers i added flag continue-on-error: true for step with send coveralls

@jenssegers
Copy link
Contributor

Awesome!

@jenssegers jenssegers merged commit 3e5e9de into mongodb:master Jan 22, 2020
mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mongo multi-version testing
2 participants