Allow to sync a single model instance #2396
Conversation
Fix `sync()` method not handling properly single model's instances passed via `$ids` argument
|
Issue #2395 |
Codecov Report
@@ Coverage Diff @@
## master #2396 +/- ##
============================================
- Coverage 87.62% 87.57% -0.05%
- Complexity 676 677 +1
============================================
Files 31 31
Lines 1551 1553 +2
============================================
+ Hits 1359 1360 +1
- Misses 192 193 +1
Continue to review full report at Codecov.
|
|
@mrneatly do you have plans to continue work with PR? |
|
@Smolevich sure, I just need to figure out what's wrong with the code style. As I know from #2438, there were some issues with StyleCI. Is it somehow related to the result of php-cs-fixer in this PR? |
|
I can't push changes to your fork as you haven't given any permissions.
|
|
Hey @divine I've sent you an invitation to my fork |
| @@ -122,7 +123,9 @@ public function sync($ids, $detaching = true) | |||
|
|
|||
| if ($ids instanceof Collection) { | |||
| $ids = $ids->modelKeys(); | |||
| } | |||
| } elseif ($ids instanceof MongodbModel) { | |||
| $ids = [$ids->{$this->relatedKey}]; | |||
There was a problem hiding this comment.
Is there a reason for not using InteractsWithPivotTable::parseIds as in the parent class?
Fix
sync()method not handling properly single model's instances passed via$idsargument