Remove calls to Str::contains and Arr::get when not necessary
#2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2023
jmikola
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
LGTM.
Per our earlier conversation in GromNaN/laravel-mongodb#27 (comment), I created PHPORM-76 to propose adding an explicit PHP language requirement to this package's composer.json file.
alcaeus
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Str::containsis identical tostr_containsbut supportarray. This is not necessary in several places.Arr::getis identical to$array[$key] ?? $defaultbut accept dot notation for nested arrays. This is not necessary when the key does not contain a dot.Replacing this method calls with native functions improve performance (less method calls) and simplifies step-by-step debugging.