Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add MorphToMany support #2670

Merged
merged 81 commits into from
Nov 22, 2023
Merged

[Feature] Add MorphToMany support #2670

merged 81 commits into from
Nov 22, 2023

Commits on Oct 12, 2023

  1. add MorphToMany 

    attach MorphToMany working

detaching works

sync working

cleanup
    @ithuis @medspec
    ithuis authored and medspec committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8eaad01 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. requested code cleanup

    @medspec
    Tycho authored and medspec committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    acfdb19 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Merge branch '4.1' into morphToMany

    @ithuis
    ithuis authored Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5a55f80 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. WIP

    @hans-thomas
    hans-thomas committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    d929456 View commit details
    Browse the repository at this point in the history

  2. WIP

    @hans-thomas
    hans-thomas committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    dd8e701 View commit details
    Browse the repository at this point in the history

  3. Add tests for MorphToMany and MorphedByMany;

    @hans-thomas
    hans-thomas committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    17a3aca View commit details
    Browse the repository at this point in the history

  4. Improve DX;

    @hans-thomas
    hans-thomas committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    4e7ad77 View commit details
    Browse the repository at this point in the history

  5. Merge branch '4.1' into 2640-morph-to-many 

    # Conflicts:
#	tests/RelationsTest.php
    @hans-thomas
    hans-thomas committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    07afe18 View commit details
    Browse the repository at this point in the history

  6. fix cs;

    @hans-thomas
    hans-thomas committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    f8240e2 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Merge branch '4.1' into 2640-morph-to-many

    @hans-thomas
    hans-thomas authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    b9ae8ab View commit details
    Browse the repository at this point in the history

  2. Querying logic in inverse mode updated;

    @hans-thomas
    hans-thomas committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    fd0a9f9 View commit details
    Browse the repository at this point in the history

  3. Attaching a collection or string id(s) fixed;

    @hans-thomas
    hans-thomas committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    dbe93d0 View commit details
    Browse the repository at this point in the history

  4. Add tests for attaching a collection;

    @hans-thomas
    hans-thomas committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    dc22fc9 View commit details
    Browse the repository at this point in the history

  5. Add tests for attaching multiple string ids;

    @hans-thomas
    hans-thomas committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a0cb480 View commit details
    Browse the repository at this point in the history

  6. WIP

    @hans-thomas
    hans-thomas committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    9f888ab View commit details
    Browse the repository at this point in the history

  7. Fix CS;

    @hans-thomas
    hans-thomas committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    3d4abab View commit details
    Browse the repository at this point in the history

  8. Detaching fixed;

    @hans-thomas
    hans-thomas committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    24119d7 View commit details
    Browse the repository at this point in the history

  9. Add tests for detaching;

    @hans-thomas
    hans-thomas committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    1833c5a View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Add tests for detaching multiple ids;

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    ad1c6ae View commit details
    Browse the repository at this point in the history

  2. Update MorphToMany.php

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    26f7ad2 View commit details
    Browse the repository at this point in the history

  3. Add test for syncing a mode;

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    8921127 View commit details
    Browse the repository at this point in the history

  4. Add test for syncing a collection of models;

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    dbaab5f View commit details
    Browse the repository at this point in the history

  5. Add test for syncing multiple ids;

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    a2c6407 View commit details
    Browse the repository at this point in the history

  6. WIP

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    284b8c3 View commit details
    Browse the repository at this point in the history

  7. Fix syncing in inverse mode

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    92040cc View commit details
    Browse the repository at this point in the history

  8. Add test for syncing a model;

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    79e5618 View commit details
    Browse the repository at this point in the history

  9. Add test for syncing a collection of models;

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    5ea4aef View commit details
    Browse the repository at this point in the history

  10. Add test for syncing multiple id;

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7008008 View commit details
    Browse the repository at this point in the history

  11. Fix CS;

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    f655f72 View commit details
    Browse the repository at this point in the history

  12. Fix eager loading relation and refreshing the model before lazy loading;

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    4932b3b View commit details
    Browse the repository at this point in the history

  13. Use load and refresh in tests;

    @hans-thomas
    hans-thomas committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    c1df501 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2023

  1. Merge branch '4.1' into 2640-morph-to-many

    @hans-thomas
    hans-thomas authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    d2b8267 View commit details
    Browse the repository at this point in the history

  2. New labelsWithCustomKeys relation defined with custom keys;

    @hans-thomas
    hans-thomas committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    c8ee4ce View commit details
    Browse the repository at this point in the history

  3. Add tests for new relation with custom keys;

    @hans-thomas
    hans-thomas committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    b4fca9d View commit details
    Browse the repository at this point in the history

  4. Merge branch '4.1' into 2640-morph-to-many

    @hans-thomas
    hans-thomas authored Nov 11, 2023
    Configuration menu
    Copy the full SHA
    7a32c98 View commit details
    Browse the repository at this point in the history

  5. New clientsWithCustomKeys defined with custom keys;

    @hans-thomas
    hans-thomas committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    db782d9 View commit details
    Browse the repository at this point in the history

  6. Add test for clientsWithCustomKeys relation;

    @hans-thomas
    hans-thomas committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    85c0159 View commit details
    Browse the repository at this point in the history

  7. Add test for load and refreshing an instance with MorphToMany relation;

    @hans-thomas
    hans-thomas committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    31dbf5e View commit details
    Browse the repository at this point in the history

  8. Add test for load and refreshing an instance with MorphedByMany relat… 

    …ion;
    @hans-thomas
    hans-thomas committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    d54f46c View commit details
    Browse the repository at this point in the history

  9. Fix CS;

    @hans-thomas
    hans-thomas committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    4026890 View commit details
    Browse the repository at this point in the history

  10. Merge branch '2640-morph-to-many' of github.com:hans-thomas/laravel-m… 

    …ongodb into 2640-morph-to-many
    @hans-thomas
    hans-thomas committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    5307e19 View commit details
    Browse the repository at this point in the history

  11. testMorphedByManyLoadAndRefreshing test updated;

    @hans-thomas
    hans-thomas committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    9e21445 View commit details
    Browse the repository at this point in the history

  12. Comments updated;

    @hans-thomas
    hans-thomas committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    0872237 View commit details
    Browse the repository at this point in the history

  13. Fix CS;

    @hans-thomas
    hans-thomas committed Nov 11, 2023
    Configuration menu
    Copy the full SHA
    77bb847 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. WIP

    @hans-thomas
    hans-thomas committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    3f3db65 View commit details
    Browse the repository at this point in the history

  2. Fix pushing relation data to the instance;

    @hans-thomas
    hans-thomas committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    1903bb4 View commit details
    Browse the repository at this point in the history

  3. Fix CS;

    @hans-thomas
    hans-thomas committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    3888115 View commit details
    Browse the repository at this point in the history

  4. Update RelationsTest.php

    @hans-thomas
    hans-thomas committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    bf990a5 View commit details
    Browse the repository at this point in the history

  5. Fix the error;

    @hans-thomas
    hans-thomas committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    9e41f46 View commit details
    Browse the repository at this point in the history

  6. Rerun the pipeline;

    @hans-thomas
    hans-thomas committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    91e0556 View commit details
    Browse the repository at this point in the history

  7. Create extractIds method;

    @hans-thomas
    hans-thomas committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    f8c322a View commit details
    Browse the repository at this point in the history

  8. Fix CS;

    @hans-thomas
    hans-thomas committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    2f83d02 View commit details
    Browse the repository at this point in the history

  9. Update MorphToMany.php

    @hans-thomas
    hans-thomas committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    e411071 View commit details
    Browse the repository at this point in the history

  10. Detach multiple ids at once;

    @hans-thomas
    hans-thomas committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    c097392 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Remove meaningless comments;

    @hans-thomas
    hans-thomas committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    711ed0f View commit details
    Browse the repository at this point in the history

  2. Pluralize using Str facade;

    @hans-thomas
    hans-thomas committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    b785d93 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Remove guessBelongsToManyRelation method;

    @hans-thomas
    hans-thomas committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    c443ca6 View commit details
    Browse the repository at this point in the history

  2. Remove getSelectColumns method;

    @hans-thomas
    hans-thomas committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f6b5112 View commit details
    Browse the repository at this point in the history

  3. Remove getQualifiedForeignPivotKeyName method; 

    Don't need to override. the result is the same as parent.
    @hans-thomas
    hans-thomas committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    0674ad6 View commit details
    Browse the repository at this point in the history

  4. Remove getForeignKey method; 

    Replace the method's result with the method.
    @hans-thomas
    hans-thomas committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    874a7d3 View commit details
    Browse the repository at this point in the history

  5. formatRecordsList replaced with deprecated formatSyncList method;

    @hans-thomas
    hans-thomas committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    add4f1c View commit details
    Browse the repository at this point in the history

  6. Remove useless condition in extractIds method;

    @hans-thomas
    hans-thomas committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    4e2766e View commit details
    Browse the repository at this point in the history

  7. Fix CS;

    @hans-thomas
    hans-thomas committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    45a0c7a View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. extractIds method returns unique ids;

    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    5d229eb View commit details
    Browse the repository at this point in the history

  2. getHasCompareKey updated;

    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    b56b90e View commit details
    Browse the repository at this point in the history

  3. Handling MorphToMany has query;

    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    ca1cc62 View commit details
    Browse the repository at this point in the history

  4. Add tests for handling has query in MorphToMany relationship;

    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    5d77236 View commit details
    Browse the repository at this point in the history

  5. Handling MorphedByMany has query;

    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    9618b84 View commit details
    Browse the repository at this point in the history

  6. getHasCompareKey removed; 

    We don't need this method anymore;
    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    6d6a99e View commit details
    Browse the repository at this point in the history

  7. Add test for MorphedByMany has query;

    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    9f53b26 View commit details
    Browse the repository at this point in the history

  8. Fix handling custom MorphedByMany has query;

    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    c4ca146 View commit details
    Browse the repository at this point in the history

  9. Add test for MorphByMany has query;

    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    989b263 View commit details
    Browse the repository at this point in the history

  10. Revert "extractIds method returns unique ids;" 

    This reverts commit 5d229eb.
    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    1817c94 View commit details
    Browse the repository at this point in the history

  11. Make extractIds method public;

    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    fc53e7d View commit details
    Browse the repository at this point in the history

  12. Add test for handling custom MorphToMany has query;

    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    d9dedf6 View commit details
    Browse the repository at this point in the history

  13. Fix CS;

    @hans-thomas
    hans-thomas committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    800bfac View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Parent morphToMany call with a minuscule "m"; 

    Co-authored-by: Andreas Braun <alcaeus@users.noreply.github.com>
    @hans-thomas @alcaeus
    hans-thomas and alcaeus authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    51b9e2a View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Add an empty line before return in handleMorphToMany method; 

    Co-authored-by: Jérôme Tamarelle <jerome@tamarelle.net>
    @hans-thomas @GromNaN
    hans-thomas and GromNaN authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    cc5bbcf View commit details
    Browse the repository at this point in the history

  2. Add an empty line before return in handleMorphedByMany method; 

    Co-authored-by: Jérôme Tamarelle <jerome@tamarelle.net>
    @hans-thomas @GromNaN
    hans-thomas and GromNaN authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    92e6389 View commit details
    Browse the repository at this point in the history

  3. Uncomment the checks of testHasManyHas;

    @hans-thomas
    hans-thomas committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    9198df9 View commit details
    Browse the repository at this point in the history

  4. Merge branch '4.1' into 2640-morph-to-many

    @GromNaN
    GromNaN authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    44c2517 View commit details
    Browse the repository at this point in the history