Improve error message for invalid configuration

CHANGELOG.md

@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file.
 
 * Fix memory leak when filling nested fields using dot notation by @GromNaN in [#2962](https://github.com/mongodb/laravel-mongodb/pull/2962)
 * Fix PHP error when accessing the connection after disconnect by @SanderMuller in [#2967](https://github.com/mongodb/laravel-mongodb/pull/2967)
+* Improve error message for invalid configuration by @GromNaN in [#2975](https://github.com/mongodb/laravel-mongodb/pull/2975)
 
 ## [4.3.0] - 2024-04-26
 

src/Connection.php

@@ -213,6 +213,8 @@ public function disconnect()
 
  /**
  * Determine if the given configuration array has a dsn string.
+ *
+ * @deprecated
  */
  protected function hasDsnString(array $config): bool
  {
@@ -261,9 +263,15 @@ protected function getHostDsn(array $config): string
  */
  protected function getDsn(array $config): string
  {
- return $this->hasDsnString($config)
- ? $this->getDsnString($config)
- : $this->getHostDsn($config);
+ if (! empty($config['dsn'])) {
+ return $this->getDsnString($config);
+ }
+
+ if (! empty($config['host'])) {
+ return $this->getHostDsn($config);
+ }
+
+ throw new InvalidArgumentException('MongoDB connection configuration requires "dsn" or "host" key.');
  }
 
  /** @inheritdoc */

tests/ConnectionTest.php

@@ -204,6 +204,14 @@ public function testConnectionWithoutConfiguredDatabase(): void
  new Connection(['dsn' => 'mongodb://some-host']);
  }
 
+ public function testConnectionWithoutConfiguredDsnOrHost(): void
+ {
+ $this->expectException(InvalidArgumentException::class);
+ $this->expectExceptionMessage('MongoDB connection configuration requires "dsn" or "host" key.');
+
+ new Connection(['database' => 'hello']);
+ }
+
  public function testCollection()
  {
  $collection = DB::connection('mongodb')->getCollection('unittest');