PHPORM-219 Deprecate Connection::collection() and Schema::collection()
#3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
PHPORM-219
branch
3 times, most recently
from
439ae56 to
c17b69a
Compare
…), to keep table() function from Laravel
3 tasks
alcaeus
reviewed
Jul 23, 2024
Co-authored-by: Andreas Braun <git@alcaeus.org>
alcaeus
approved these changes
Jul 23, 2024
rustagir
approved these changes
Jul 23, 2024
|
Thank you @rustagir, I really appreciate your intervention. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-219
The method MongoDB\Laravel\Connection::collection()is an alias for Laravel’sIlluminate\Database\ConnectionInterface::table(). I guess it was introduced when the package was created to fit MongoDB terminology.Removing this custom name fit with Laravel and remove the one of the 2 ways of doing the same thing.
Checklist