Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-41621: upsert #3089

Merged
merged 12 commits into from
Aug 12, 2024
Merged

DOCSP-41621: upsert #3089

merged 12 commits into from
Aug 12, 2024

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Jul 31, 2024 •
edited
Loading

Adds documentation and tests for upsert method

https://jira.mongodb.org/browse/DOCSP-41621
Staging:

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

@github-actions github-actions bot added the docs label Jul 31, 2024
@rustagir rustagir marked this pull request as ready for review August 1, 2024 15:18
@rustagir rustagir requested a review from a team as a code owner August 1, 2024 15:18
norareidy
norareidy approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor suggestions

docs/fundamentals/write-operations.txt Outdated Show resolved Hide resolved
docs/fundamentals/write-operations.txt Outdated Show resolved Hide resolved
docs/fundamentals/write-operations.txt Outdated Show resolved Hide resolved
docs/query-builder.txt Outdated Show resolved Hide resolved
@GromNaN GromNaN requested review from GromNaN and removed request for alcaeus August 12, 2024 09:17
GromNaN
GromNaN reviewed Aug 12, 2024
View reviewed changes
docs/fundamentals/write-operations.txt Outdated Show resolved Hide resolved
docs/fundamentals/write-operations.txt Outdated Show resolved Hide resolved
docs/query-builder.txt Show resolved Hide resolved
@rustagir rustagir requested a review from GromNaN August 12, 2024 14:58
@rustagir rustagir merged commit 185d93a into mongodb:4.7 Aug 12, 2024
26 checks passed
This was referenced Aug 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

@norareidy norareidy norareidy approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustagir @GromNaN @norareidy