Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPORM-227 Fix single document upsert #3100

Merged
merged 1 commit into from
Aug 26, 2024
Merged

PHPORM-227 Fix single document upsert #3100

merged 1 commit into from
Aug 26, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Aug 13, 2024

Fix PHPORM-227

Caused by #3053

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

@GromNaN GromNaN requested a review from a team as a code owner August 13, 2024 15:15
@GromNaN GromNaN requested a review from mana2-bot August 13, 2024 15:15
@GromNaN GromNaN added the bug label Aug 13, 2024
@GromNaN GromNaN added this to the 4.7 milestone Aug 13, 2024
@GromNaN GromNaN requested review from alcaeus and removed request for mana2-bot August 13, 2024 15:21
@GromNaN GromNaN changed the base branch from 4.8 to 4.7 August 13, 2024 15:21
alcaeus
alcaeus reviewed Aug 26, 2024
View reviewed changes
src/Query/Builder.php Outdated Show resolved Hide resolved
alcaeus
alcaeus approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to add the array_is_list improvement before merging.

@GromNaN GromNaN enabled auto-merge (squash) August 26, 2024 15:46
@GromNaN GromNaN merged commit efab63b into mongodb:4.7 Aug 26, 2024
26 checks passed
@mongodb-php-bot mongodb-php-bot mentioned this pull request Aug 26, 2024
Merged
@GromNaN GromNaN deleted the PHPORM-227 branch August 26, 2024 18:33
@mongodb-php-bot mongodb-php-bot mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.7
Development

Successfully merging this pull request may close these issues.
2 participants
@GromNaN @alcaeus