Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-43158: carbon date values db query results #3133

Merged
merged 3 commits into from
Sep 5, 2024
Merged

DOCSP-43158: carbon date values db query results #3133

merged 3 commits into from
Sep 5, 2024

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Sep 4, 2024 •
edited
Loading

adds docs for the change that converts bson utc dates to carbon dates
https://jira.mongodb.org/browse/DOCSP-43158

STAGING:

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file

@github-actions github-actions bot added the docs label Sep 4, 2024
mcmorisi
mcmorisi approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rustagir rustagir marked this pull request as ready for review September 4, 2024 16:24
@rustagir rustagir requested a review from a team as a code owner September 4, 2024 16:24
GromNaN
GromNaN approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other breaking changes that will need to be added to this chapter:

  • _id is renamed to id in db results (including in subdocuments)
  • the database query builder return stdClass objects instead of array

@rustagir rustagir merged commit 807f5fa into mongodb:5.0 Sep 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

@mcmorisi mcmorisi mcmorisi approved these changes

@norareidy norareidy norareidy approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rustagir @GromNaN @mcmorisi @norareidy