Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to countDocuments method #3142

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Add options to countDocuments method #3142

merged 2 commits into from
Sep 11, 2024

Conversation

verduck
Copy link
Contributor

@verduck verduck commented Sep 11, 2024 •
edited by GromNaN
Loading

Added $this->options to inheritConnectionOptions, enabling options to be passed to the countDocuments method when calling count().

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file

@verduck verduck requested a review from a team as a code owner September 11, 2024 06:36
@verduck verduck requested a review from alcaeus September 11, 2024 06:36
@GromNaN GromNaN requested review from GromNaN and removed request for alcaeus September 11, 2024 06:46
GromNaN
GromNaN approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @verduck for this perfect PR.

@GromNaN GromNaN enabled auto-merge (squash) September 11, 2024 07:55
@GromNaN GromNaN merged commit 25a6e9e into mongodb:5.0 Sep 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@verduck @GromNaN