Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-43530: Id field in query results #3149

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Sep 12, 2024

mongodb-php-bot and others added 2 commits September 12, 2024 12:50
Co-authored-by: Jérôme Tamarelle <jerome.tamarelle@mongodb.com>
@github-actions github-actions bot added the docs label Sep 12, 2024
@norareidy norareidy marked this pull request as ready for review September 12, 2024 20:57
@norareidy norareidy requested a review from a team as a code owner September 12, 2024 20:57
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minor wording changes

Comment on lines 198 to 200
code. When you run a find operation using the query builder, the {+odm-short+}
automatically converts between ``id`` and ``_id``. In query results,
the ``_id`` field is renamed to ``id``. This provides better
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: avoid using

Suggested change
code. When you run a find operation using the query builder, the {+odm-short+}
automatically converts between ``id`` and ``_id``. In query results,
the ``_id`` field is renamed to ``id``. This provides better
code. When you use the query builder to run a find operation, the {+odm-short+}
automatically converts between ``_id`` and``id`` field names. In query results,
the ``_id`` field is presented as ``id``. This provides better

automatically converts between ``id`` and ``_id``. This provides better
code. When you run a find operation using the query builder, the {+odm-short+}
automatically converts between ``id`` and ``_id``. In query results,
the ``_id`` field is renamed to ``id``. This provides better
compatibility with Laravel, as the framework assumes that each record has a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
compatibility with Laravel, as the framework assumes that each record has a
consistency with Laravel, as the framework assumes that each record has a

@norareidy norareidy changed the base branch from 5.x to 5.0 September 13, 2024 15:14
@norareidy norareidy requested a review from a team as a code owner September 13, 2024 15:14
@norareidy norareidy merged commit 98474c3 into mongodb:5.0 Sep 13, 2024
27 checks passed
@norareidy norareidy deleted the DOCSP-43530-result-id-field branch September 13, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants