PHPORM-239 Convert _id and UTCDateTime in results of Model::raw() before hydratation
#3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see any way to change this behavior without breaking backward compatibility. |
GromNaN
force-pushed
the
PHPORM-239
branch
2 times, most recently
from
10c98ee
to
7f0b77e
Compare
alcaeus
reviewed
Sep 17, 2024
|
|
||
| return $this->model->newFromBuilder((array) $results); | ||
| // Convert MongoDB Document to a single object. | ||
| if (is_object($results) && (property_exists($results, '_id') || property_exists($results, 'id'))) { |
There was a problem hiding this comment.
Confirmed that PHP correctly calls the has_property handler when using property_exists: https://github.com/php/php-src/blob/1be989bbf0e46db8438384db184fca424392cfef/Zend/zend_builtin_functions.c#L1020..L1023
GromNaN
changed the title
_id and UTCDateTime in results of Model::raw() before hydratation
|
LGTM, but tests need a little more work. |
GromNaN
commented
Sep 17, 2024
Comment on lines
+946
to
+947
| $this->assertEquals(['foo' => 'bar'], (array) $user->embed); | ||
| $this->assertEquals([1, 2, 3], (array) $user->list); |
There was a problem hiding this comment.
We don't convert nested documents and array into array for single result. This is easily done for cursor and BSON documents with typemap.
GromNaN
commented
Sep 17, 2024
Comment on lines
+1385
to
+1403
| yield 'raw filter with _id and date' => [ | ||
| [ | ||
| 'find' => [ | ||
| [ | ||
| '$and' => [ | ||
| [ | ||
| '$or' => [ | ||
| ['foo._id' => 1], | ||
| ['created_at' => ['$gte' => new UTCDateTime(new DateTimeImmutable('2018-09-30 00:00:00.000 +00:00'))]], | ||
| ], | ||
| ], | ||
| ['age' => 15], | ||
| ], | ||
| ], | ||
| [], // options | ||
| ], | ||
| ], | ||
| fn (Builder $builder) => $builder->where([ | ||
| '$or' => [ |
There was a problem hiding this comment.
Added this test case to ensure DB::where($filter)->get() is identical to $collection->find($filter) (for the doc team).
alcaeus
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-239
Fix #3151
Checklist