Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPORM-241 Add return type to CommandSubscriber #3157

Merged
merged 1 commit into from
Sep 16, 2024
Merged

PHPORM-241 Add return type to CommandSubscriber #3157

merged 1 commit into from
Sep 16, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Sep 13, 2024 •
edited
Loading

Fix PHPORM-241
Fix #3153

The interface has the void return type according to the stubs.

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file

@GromNaN GromNaN marked this pull request as ready for review September 13, 2024 19:34
@GromNaN GromNaN requested a review from a team as a code owner September 13, 2024 19:34
@GromNaN GromNaN mentioned this pull request Sep 13, 2024
Closed
@GromNaN GromNaN added this to the 5.0 milestone Sep 13, 2024
@GromNaN GromNaN merged commit a516427 into mongodb:5.x Sep 16, 2024
27 checks passed
@GromNaN GromNaN deleted the PHPORM-241 branch September 16, 2024 06:56
@GromNaN GromNaN mentioned this pull request Sep 17, 2024
Merged
2 tasks
@GromNaN GromNaN added the bug label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

MongoDB\Driver\Monitoring\CommandSubscriber interface signature
2 participants
@GromNaN @alcaeus