PHPORM-248 register command subscriber only when logs are enabled #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
requested review from
alcaeus and
jmikola
and removed request for
alcaeus
alcaeus
requested changes
Oct 4, 2024
src/Connection.php
Outdated
| { | ||
| parent::disableQueryLog(); // TODO: Change the autogenerated stub | ||
|
|
||
| $this->connection->removeSubscriber($this->commandSubscriber); |
There was a problem hiding this comment.
Needs a safe guard in case no subscriber is registered
There was a problem hiding this comment.
Added a condition to never add or remove the subscriber twice.
alcaeus
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-248
Fix #3166
The command subscriber has significant impact on command execution. It can be enabled only when necessary.
Checklist