Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-44158: Convert arrow to dot notation #3173

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Oct 11, 2024

@github-actions github-actions bot added the docs label Oct 11, 2024
@norareidy norareidy marked this pull request as ready for review October 11, 2024 15:44
@norareidy norareidy requested a review from a team as a code owner October 11, 2024 15:44
docs/query-builder.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 226 to 228
In v5.1, you can use the arrow (``->``) or dot (``.``) notation
to access nested fields in a query filter. The preceding example
uses the dot notation to query the ``imdb.rating`` nested field, but
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think "arrow notation" and "dot notation" without "the" is more common? Disregard if this is the laravel-specific terminology though

Suggested change
In v5.1, you can use the arrow (``->``) or dot (``.``) notation
to access nested fields in a query filter. The preceding example
uses the dot notation to query the ``imdb.rating`` nested field, but
In v5.1, you can use arrow (``->``) or dot (``.``) notation
to access nested fields in a query filter. The preceding example
uses dot notation to query the ``imdb.rating`` nested field, but

@norareidy norareidy changed the base branch from 5.x to 5.1 October 11, 2024 18:18
@norareidy norareidy merged commit f6536fe into mongodb:5.1 Oct 11, 2024
27 checks passed
@norareidy norareidy deleted the DOCSP-44158-arrow-dot-notation branch October 11, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants