Skip to content

DOCSP-49324: dedicated session handler #3364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2025

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Apr 18, 2025

https://jira.mongodb.org/browse/DOCSP-49324

adds a note that distinguishes that v5.4 introduces a dedicated session handler.

staging

Checklist

  • Add tests and ensure they pass

@rustagir rustagir requested a review from a team as a code owner April 18, 2025 13:20
@rustagir rustagir requested a review from norareidy April 18, 2025 13:20
@github-actions github-actions bot added the docs label Apr 18, 2025
@rustagir rustagir requested a review from GromNaN April 18, 2025 13:23
@GromNaN
Copy link
Member

GromNaN commented Apr 18, 2025

Perhaps we could say it's new in this version, as it wasn't really usable in previous versions.

@GromNaN
Copy link
Member

GromNaN commented Apr 18, 2025

I added this sentence to the release note:

The user id, IP address and user agent are now saved by the `mongodb' session driver if available.

Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit!

@GromNaN GromNaN enabled auto-merge (squash) April 18, 2025 14:08
@rustagir rustagir requested review from lindseymoore and removed request for norareidy April 18, 2025 15:14
Copy link
Collaborator

@lindseymoore lindseymoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to merge!

@GromNaN GromNaN merged commit db71580 into mongodb:5.4 Apr 18, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants