PHPORM-264: Deprecate Mongo soft deletes trait #3408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustagir
approved these changes
Jun 16, 2025
Contributor
rustagir
left a comment
rustagir
left a comment
There was a problem hiding this comment.
changes to docs tests lgtm
GromNaN
requested changes
Jun 23, 2025
Collaborator
Author
|
Sorry this took me so long @GromNaN. Question, why do we trigger an |
Member
|
GromNaN
approved these changes
Jun 30, 2025
Collaborator
Author
|
Gotcha, thank you! |
In favor of the Laravel one. Ours is now obsolete; the SoftDeletes trait is only necessary to remove the call to qualifyColumn in the parent trait. But the DocumentModel::qualifyColumn is already disabled
Member
|
The CI is stuck because of the github-actions[bot] commit. You can rebase/squash an push. |
Co-authored-by: Jérôme Tamarelle <jerome@tamarelle.net>
paulinevos
force-pushed
the
264_deprecrate-soft-deletes
branch
from
e99646e to
ece1a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In favor of the Laravel one. Ours is now obsolete; the SoftDeletes trait is only necessary to remove the call to qualifyColumn in the parent trait. But the DocumentModel::qualifyColumn is already disabled.
Also replaces some internal/test usages with the recommended trait.
Closes PHPORM-264
Checklist