LG-3313: v10 Row props #1916
Merged
LG-3313: v10 Row props #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…afygreen-ui into LG-3313-v10-row-props
🦋 Changeset detectedLatest commit: 727ca89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +494 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
bruugey
reviewed
Aug 21, 2023
| @@ -127,6 +152,8 @@ const V11Adapter = <T extends LGRowData>({ | |||
| virtualRow={ | |||
| useVirtualScrolling ? (iterable as VirtualItem) : undefined | |||
| } | |||
| // @ts-expect-error rowProps is an additional prop passed by the `processData` function | |||
There was a problem hiding this comment.
why do we need to ts-expect-error here?
There was a problem hiding this comment.
We should fix the types in the processData function rather than add expect error
| @@ -127,6 +152,8 @@ const V11Adapter = <T extends LGRowData>({ | |||
| virtualRow={ | |||
| useVirtualScrolling ? (iterable as VirtualItem) : undefined | |||
| } | |||
| // @ts-expect-error rowProps is an additional prop passed by the `processData` function | |||
There was a problem hiding this comment.
We should fix the types in the processData function rather than add expect error
Comment on lines
+128
to
+132
| // @ts-expect-error | ||
| <HeaderCell | ||
| key={header.id} | ||
| header={header} | ||
| {...oldHeaderCellProps[i]} |
There was a problem hiding this comment.
We should update/cast the type of oldHeaderCellProps rather than expect error
| </Row> | ||
| ))} | ||
| row.subRows.map(subRow => { | ||
| // @ts-expect-error rowProps is an additional prop passed by the `processData` function |
| <Row key={subRow.id} row={subRow} {...subRowProps}> | ||
| {subRow.getVisibleCells().map(srCell => { | ||
| /* @ts-expect-error subRow.original returns the object in the user's defined shape, and should be string indexable */ | ||
| const subRowCell = subRow.original[srCell.column.id](); |
There was a problem hiding this comment.
Seems there are a lot of issues with the TS type of row.original vs how it's used. We should fix those
There was a problem hiding this comment.
agree that we should fix htis.
TheSonOfThomp
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes