-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-3569: dropdown borders #1984
Conversation
🦋 Changeset detectedLatest commit: a204c9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +41 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
Shocked that this caused no flag in Chromatic |
packages/search-input/src/SearchResultsMenu/SearchResultsMenu.style.ts
Outdated
Show resolved
Hide resolved
yeah, it should show a 1px shift in the dropdowns |
✍️ Proposed changes
Updates
SearchInput
andSelect
dropdowns.Updates to
Select
will updateNumberInput
,Pagination
, andLanguageSwitcher
.Combobox
already has the correct border.🎟 Jira ticket: LG-3569
✅ Checklist
For bug fixes, new features & breaking changes
yarn changeset
and documented my changesFor new components
🧪 How to test changes