Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-3592: SearchResultsMenu popoverProps; footerSlot prop #1986

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

spark33
Copy link
Contributor

@spark33 spark33 commented Sep 18, 2023

✍️ Proposed changes

🎟 Jira ticket: LG-3592

✅ Checklist

For bug fixes, new features & breaking changes

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • I have run yarn changeset and documented my changes

For new components

  • I have added my new package to the global tsconfig
  • I have added my new package to the Table of Contents on the global README
  • I have verified the Live Example looks as intended on the design website.

🧪 How to test changes

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

🦋 Changeset detected

Latest commit: 63bd45d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@leafygreen-ui/popover Minor
@leafygreen-ui/search-input Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

yarn.lock Outdated Show resolved Hide resolved
@spark33 spark33 force-pushed the LG-3592-pass-popover-props-in-search-results-menu branch from ae2c1dc to 5b78b2a Compare September 18, 2023 20:57
@spark33 spark33 changed the title LG-3592: SearchResultsMenu popoverProps LG-3592: SearchResultsMenu popoverProps; footerSlot prop Sep 18, 2023
@spark33 spark33 merged commit f669836 into main Sep 19, 2023
@spark33 spark33 deleted the LG-3592-pass-popover-props-in-search-results-menu branch September 19, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants