[DEVHUB-1898, UP-6913] Add Hotkey Indicator to Chat InputBar Component #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9b53526 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
max-melo
force-pushed
the
mm/lg-chat-hotkey-indicator
branch
from
38750a9 to
166e450
Compare
|
Size Change: +910 B (+0.07%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
stephl3
reviewed
Sep 11, 2024
bruugey
reviewed
Sep 12, 2024
bruugey
approved these changes
Sep 12, 2024
…ldRenderHotkeyIndicator is true
|
@stephl3 I tried utilizing I'm also wondering if I should swap over the prop name to something else now that it controls both the presentational and the interactive elements. If you have any suggestions (or think that the current prop name is fine), let me know! |
stephl3
reviewed
Sep 13, 2024
Comment on lines
345
to
352
| useEventListener('keydown', (e: KeyboardEvent) => { | ||
| if ( | ||
| !e.repeat && | ||
| e.key === '/' && | ||
| shouldRenderHotkeyIndicator && | ||
| !isFocused && | ||
| textareaRef.current | ||
| ) { |
There was a problem hiding this comment.
useEventListener takes an optional 3rd argument of option. There's an enabled param that can contain some of the if statements
Suggested change
| useEventListener('keydown', (e: KeyboardEvent) => { | |
| if ( | |
| !e.repeat && | |
| e.key === '/' && | |
| shouldRenderHotkeyIndicator && | |
| !isFocused && | |
| textareaRef.current | |
| ) { | |
| useEventListener('keydown', (e: KeyboardEvent) => { | |
| if ( | |
| !e.repeat && | |
| e.key === '/' | |
| ) { | |
| ... | |
| } | |
| }, | |
| shouldRenderHotkeyIndicator & | |
| !isFocused && | |
| textareaRef.current, | |
| ); |
There was a problem hiding this comment.
Just fyi, had to keep the textareaRef.current check inside the hook body because of a failing test -- I think the component wasn't being re-rendered when the ref attached resulting in the hook being out-of-date (i.e. enabled stayed false and it wasn't picking up any keyboard inputs when it should have been)
| !isFocused && | ||
| textareaRef.current | ||
| ) { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
does this also need e.stopPropagation()? when I tested it in storybook, the hotkey is overridden by storybook's / hotkey
| ) { | ||
| e.preventDefault(); | ||
| textareaRef.current.focus(); | ||
| setIsFocused(true); |
There was a problem hiding this comment.
TextareaAutosize has an onFocus listener that also calls setIsFocused(true);. Does it need to be called here as well or should we drop this one?
weird, I wonder why that is. maybe something to do with how the styles are applied by emotion. the animation approach looks good!
not really sure. couple other ideas I can think of are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Adds
shouldRenderHotkeyIndicatorprop to the InputBar component for chat. This is going to be used for the chatbot integration on DevCenter and University.First time raising a PR to LG, so let me know if I missed anything
🎟 Jira ticket: DEVHUB-1898, UP-6913
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes
Hotkey indicator should be shown when the
shouldRenderHotkeyIndicatorprop is set to true: