LG-4952: Updates Modal component to use dialog element #2579
+599
−515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cb6aaa3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bruugey
commented
Dec 5, 2024
| return ( | ||
| <PopoverProvider> | ||
| <LeafyGreenProvider> | ||
| <dialog |
There was a problem hiding this comment.
wondering if we should deprecate contentClassName in favor of className since there's only one element now?
|
Size Change: -2.05 kB (-0.15%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
bruugey
changed the title
…ui into brooke/modal-updates
| @@ -215,3 +271,20 @@ console.log(greeting('World')); | |||
| </div> | |||
| ); | |||
| } | |||
|
|
|||
| export function TooltipTrigger(args: ModalProps) { | |||
There was a problem hiding this comment.
Should also either have the tooltip open immediately, or write a play function so this gets checked in Chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: LG-4952
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes