LG-4662: Fix CommonJS imports #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8ddbd58 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: -218 B (-0.02%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
shaneeza
approved these changes
Dec 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 30, 2024
* Revert "LG-4662: Fix CommonJS imports (#2587)" This reverts commit 6e37cfa. * Working state * Move adding group logic to echart * Working state * Working state * Small fix * typo * Shorten names * Improve typing * Working order * Re-org * Add instance check * Share ChartInstance * Fix imports * Tests * Lint * changeset * Add theme prop * Lint * Turn zoom select on both charts in storybook * CR Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This issue has to do with the ECharts treeshaking interface (see "Shrinking Bundle Size"). Instead of importing from
echartsdirectly, imports come from sub-packages such asecharts/coreandecharts/charts. Importing these directly into a node script viarequire()proved to throw the same error we're seeing.This PR goes back to just importing from
echarts. I've checked the bundle sizes being output on build and am not seeing a diff. Once this is published I will double check the bundle size to confirm that this is not bloating it too dramatically. If it is, we may need to turn to dynamic imports instead.🎟 Jira ticket: LG-4662
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes
I tested this locally by importing the built dist into a node file and running it. Before this change the error was thrown, after the change it wasn't. I also confirmed that everything still appears to be working as expected in Storybook.