Update button package test harnesses #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d2fed88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +138 B (+0.01%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
stephl3
force-pushed
the
steph/button-test-harnesses
branch
from
7956978 to
8573d3a
Compare
.changeset/late-chefs-build.md
Outdated
| '@lg-tools/test-harnesses': minor | ||
| --- | ||
|
|
||
| Export `queryByLgId` util |
There was a problem hiding this comment.
Export findByLgId, getByLgId, queryByLgId
TheSonOfThomp
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR is an initial stab at addressing 2 issues with our current test harnesses approach demonstrated in
@leafygreen-ui/button.findButtonandqueryButtontest utilsdata-lgidprop does not propagate to nested elements in the root componentLGIDS_BUTTONobject (in other packages, this may be namedLGIDs,LGIDS, orLGIDS_*) with agetLgIdsutil which can be used to propagate/interpolate thedata-lgidprop into all the other keysdata-lgidon the root. If you consider select test utils, you can think about: how do you test for asserting a specific label or description is present when multipleSelectinstances are rendered?🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes