Skip to content

ci(NODE-5088): download node to local directory #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 16, 2023
Merged

ci(NODE-5088): download node to local directory #585

merged 4 commits into from
Mar 16, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Mar 3, 2023

Description

What is changing?

Add nodejs fetching script from mongodb/node-mongodb-native#3583

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review March 7, 2023 15:56
@durran durran added the js-team-review Needs final review from Node.js team label Mar 9, 2023
@durran durran merged commit 0453650 into master Mar 16, 2023
@durran durran deleted the NODE-5088-node-script branch March 16, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@durran durran durran approved these changes

@baileympearson baileympearson baileympearson approved these changes

@dariakp dariakp Awaiting requested review from dariakp

@addaleax addaleax Awaiting requested review from addaleax

Assignees

@durran durran

Labels

js-team-review Needs final review from Node.js team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nbbeeken @durran @baileympearson