[r2.1] CDRIVER-6112 fix ownership transfer of mongoc_write_command_t
#2136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odb#2132) * add regression test * do not memcpy `bson_t` struct in array * `memcpy` does not correctly transfer ownership of `bson_t`. Instead: heap allocate `bson_t`. * warn against using `bson_t` in `mongoc_array_t`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies changes from #2132 to r2.1 branch to include in 2.1.2 release.
ac38749 was cherry-picked and manually fixed to match formatting on r2.1 (6ccc0ae changed formatting on master, and is not on r2.1).