CSHARP-4872: Add support for Append in aggregate expressions. #1569
Conversation
|
This adds support for Append in expressions. It does not add support for top-level IQueryable Append. I'm not sure if there is a good way to support top-level Append in MQL. Perhaps with a |
| else | ||
| { | ||
| elementTranslation = ExpressionToAggregationExpressionTranslator.TranslateEnumerable(context, elementExpression); | ||
| if (!elementTranslation.Serializer.Equals(itemSerializer)) |
There was a problem hiding this comment.
Should we check for compatible serializers instead? For example if collection is of long and appended item is int.
There was a problem hiding this comment.
That should never happen. By the time we get here both serializers will always have the exact same ValueType.
The only question is whether they are serialized the same way.
|
|
||
| namespace MongoDB.Driver.Tests.Linq.Linq3Implementation.Jira | ||
| { | ||
| public class CSharp4872Tests : Linq3IntegrationTest |
There was a problem hiding this comment.
Should I be able to Append int to collection of longs?
There was a problem hiding this comment.
Yes, but...
The compiler will insert a Convert from int to long so in the end you are actually appending a long.
2 participants
No description provided.