Skip to content

CSHARP-4876: Support OfType in nested expressions. #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

rstam
Copy link
Contributor

@rstam rstam commented Dec 8, 2024

No description provided.

@rstam rstam requested a review from sanych-sun December 8, 2024 00:02
@rstam rstam requested a review from a team as a code owner December 8, 2024 00:02
@rstam rstam changed the title CSHARP-4876: Sort OfType in nested expressions. CSHARP-4876: Support OfType in nested expressions. Dec 10, 2024
@rstam rstam requested a review from adelinowona December 19, 2024 16:20
{
var sourceExpression = arguments[0];
var sourceTranslation = ExpressionToAggregationExpressionTranslator.TranslateEnumerable(context, sourceExpression);
NestedAsQueryableHelper.EnsureQueryableMethodHasNestedAsQueryableSource(expression, sourceTranslation);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this check?

@rstam rstam requested a review from sanych-sun December 30, 2024 20:44
Copy link
Contributor

@adelinowona adelinowona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@sanych-sun sanych-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rstam rstam merged commit cfb662f into mongodb:main Jan 14, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants