Skip to content

CSHARP-5541: move rankFusion methods to IAggregateFluentExtensions #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

adelinowona
Copy link
Contributor

No description provided.

@adelinowona adelinowona requested a review from a team as a code owner March 27, 2025 18:12
@adelinowona adelinowona requested review from JamesKovacs, rstam and BorisDog and removed request for a team and JamesKovacs March 27, 2025 18:12
@rstam
Copy link
Contributor

rstam commented Mar 27, 2025

I'm thinking about this before reviewing further. It feels so wrong.

Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanych-sun sanych-sun added the chore Label to hide PR from generated Release Notes label Mar 27, 2025
Copy link
Contributor

@rstam rstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels wrong, but sounds like our hand is forced. We should consider switching from interfaces to classes for our public API in 4.0.

@adelinowona adelinowona merged commit 693ea35 into mongodb:main Mar 27, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Label to hide PR from generated Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants