Fix runtime errors during execution of etc/make_release.py #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix issues which are currently blocking the release process.
Important
These changes must be merged prior to release to ensure consistency between the release tag and the (signed) distribution tarball contents.
#1244 overlooked the removal of the removal of the
distutilspackage in Python 3.12.#1244 overlooked a reference to the
install-c-driver.shscript inetc/make_release.pywhich was not updated to match the new name of the script (formerlyinstall_c_driver.sh).#1266 overlooked the required addition of
ENABLE_TESTS=ONduring execution of both theetc/make_release.pyand thedistchecktarget commands, which currently end up excluding all test files in the distribution tarball.