Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2657 Restrict getNonce spec tests to < 6.2. #1147

Merged
merged 1 commit into from
Dec 15, 2022
Merged

GODRIVER-2657 Restrict getNonce spec tests to < 6.2. #1147

merged 1 commit into from
Dec 15, 2022

Conversation

benjirewis
Copy link
Contributor

GODRIVER-2657

Summary

Syncs spec tests with this commit.

Background & Motivation

Support for the getNonce command will be removed in server version 6.2. This updates spec tests that send getNonce to the server to only run on 6.1.99 and below. The only usage of getNonce we have otherwise is in the MongoDBCR authentication system, which we've "deprecated". The mongdbcr_test.go mocks connections for writing and reading messages, so getNonce is never actually sent to a server.

Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjirewis benjirewis merged commit 59c6453 into mongodb:master Dec 15, 2022
@benjirewis benjirewis deleted the 2657 branch December 15, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants