GODRIVER-2782 Resolve updated revive v1.3.1 lint errors. #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewdale These fixes will require updating the CI's instance of "golangci-lint" to latest. It was pinned in PR #1210 to ensure green builds and avoid overlooking other static analysis errors. |
matthewdale
force-pushed
the
godriver2782-fix-revive
branch
from
675d6f7
to
0ca1637
Compare
|
@prestonvasquez thank you for the heads up! I've updated the pinned version of |
prestonvasquez
approved these changes
Mar 29, 2023
matthewdale
force-pushed
the
godriver2782-fix-revive
branch
from
0ca1637
to
e5282b8
Compare
matthewdale
force-pushed
the
godriver2782-fix-revive
branch
from
e5282b8
to
0a543c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2782
Summary
golangci-lintversion to v1.52.2golangci-lintupgradingrevivefrom v1.3.0 to v1.3.1.Background & Motivation
The latest version of the
golangci-linttool upgradedrevivefrom v1.3.0 to v1.3.1 (see PR), which adds some additional useful code checks.