Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2929 Add the ability to join multiple errors into one. #1370

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

matthewdale
Copy link
Collaborator

GODRIVER-2929

Summary

Add errutil.Join, which provides the ability to join multiple errors into one.

Background & Motivation

Go 1.20 adds the errors.Join function that can join multiple "sibling" errors into one (e.g. multiple errors that happen when retrying an operation). Add a similar method to the "internal/errutil" package that works similarly both Go 1.20+ and for earlier Go versions.

@matthewdale matthewdale requested a review from a team as a code owner August 31, 2023 21:26
@matthewdale matthewdale requested review from prestonvasquez and removed request for a team August 31, 2023 21:26
@matthewdale matthewdale temporarily deployed to api-report August 31, 2023 21:26 — with GitHub Actions Inactive
@github-actions
Copy link

API Change Report

No changes found!

@matthewdale matthewdale force-pushed the godriver2929-join-errs branch from f961055 to 807b2f9 Compare September 2, 2023 05:34
@matthewdale matthewdale temporarily deployed to api-report September 2, 2023 05:34 — with GitHub Actions Inactive
@matthewdale matthewdale force-pushed the godriver2929-join-errs branch from 807b2f9 to 9396361 Compare September 2, 2023 06:29
prestonvasquez
prestonvasquez previously approved these changes Sep 11, 2023
prestonvasquez
prestonvasquez previously approved these changes Sep 14, 2023
@matthewdale matthewdale changed the base branch from v1 to master September 20, 2023 04:39
@matthewdale matthewdale dismissed prestonvasquez’s stale review September 20, 2023 04:39

The base branch was changed.

Copy link
Collaborator

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is pointing at master but is intended for v1, given the title of GODRIVER-2929: "Improve error messaging by wrapping errors in Go Driver 1.x"

It appears it should be merged into v1.

@matthewdale matthewdale merged commit 848b7c2 into mongodb:master Nov 4, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants