GODRIVER-2929 Add the ability to join multiple errors into one. #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewdale
requested review from
prestonvasquez
and removed request for
a team
API Change ReportNo changes found! |
matthewdale
force-pushed
the
godriver2929-join-errs
branch
from
f961055 to
807b2f9
Compare
matthewdale
temporarily deployed
to
api-report
GitHub Actions
Inactive
matthewdale
force-pushed
the
godriver2929-join-errs
branch
from
807b2f9 to
9396361
Compare
matthewdale
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
previously approved these changes
Sep 11, 2023
matthewdale
force-pushed
the
godriver2929-join-errs
branch
from
9396361 to
f5b5782
Compare
matthewdale
had a problem deploying
to
api-report
GitHub Actions
Failure
matthewdale
force-pushed
the
godriver2929-join-errs
branch
from
f5b5782 to
58e7187
Compare
matthewdale
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
previously approved these changes
Sep 14, 2023
matthewdale
had a problem deploying
to
api-report
GitHub Actions
Failure
matthewdale
dismissed
prestonvasquez’s stale review
The base branch was changed.
matthewdale
force-pushed
the
godriver2929-join-errs
branch
from
3847d17 to
4c98d14
Compare
matthewdale
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
This PR is pointing at master but is intended for v1, given the title of GODRIVER-2929: "Improve error messaging by wrapping errors in Go Driver 1.x"
It appears it should be merged into v1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2929
Summary
Add
errutil.Join, which provides the ability to join multiple errors into one.Background & Motivation
Go 1.20 adds the errors.Join function that can join multiple "sibling" errors into one (e.g. multiple errors that happen when retrying an operation). Add a similar method to the "internal/errutil" package that works similarly both Go 1.20+ and for earlier Go versions.