-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-2800 Convert Session Interface to a Struct #1592
Conversation
API Change Report./mongoincompatible changes##(Client).StartSession: changed from func(..../mongo/options.SessionOptions) (Session, error) to func(...*./mongo/options.SessionOptions) (*Session, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Edit:
There are two undefined symbol compilation errors:
internal/integration/client_side_encryption_test.go:146:23: undefined: mongo.ContextWithSession
internal/integration/client_side_encryption_test.go:210:23: undefined: mongo.ContextWithSession
Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
GODRIVER-2800
Summary
Replace the session interface with a struct.
Background & Motivation
Currently there is only one implementation of the Session interface in the Go Driver, the sessionImpl struct. This is confusing to users since we export the Session interface but seal it from external use. Following best practices, we should investigating converting the session interface to a struct.